Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7479] - Add test for Linode VPC config not recommended notices #10781

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented Aug 13, 2024

Description 📝

Add Cloud Manager UI tests using mock API data to confirm that informational notices appear when adding a Linode config using non-recommended settings.

Changes 🔄

  • Add a new test in packages/manager/cypress/e2e/core/linodes/linode-config.spec.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Aug 13, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner August 13, 2024 18:26
@AzureLatte AzureLatte requested review from cliu-akamai and removed request for a team August 13, 2024 18:26
@AzureLatte AzureLatte requested a review from a team as a code owner August 13, 2024 18:27
@AzureLatte AzureLatte requested review from mjac0bs and hana-linode and removed request for a team August 13, 2024 18:27
Copy link

github-actions bot commented Aug 13, 2024

Coverage Report:
Base Coverage: 82.46%
Current Coverage: 82.46%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the coverage, @AzureLatte.

I noticed we're testing for NOT_NATTED_HELPER_TEXT in a test case before this one. Do you think it would make sense to move that out of here and down to this test, where checking for unrecommended configs is the focus?

@AzureLatte
Copy link
Contributor Author

Thanks for the coverage, @AzureLatte.

I noticed we're testing for NOT_NATTED_HELPER_TEXT in a test case before this one. Do you think it would make sense to move that out of here and down to this test, where checking for unrecommended configs is the focus?

Thanks for the comment. IMO I don't think it is necessary to move NOT_NATTED_HELPER_TEXT here considering it is also part of assertion required for "Creates a new config and assigns a VPC as a network interface". @jdamore-linode @cliu-akamai What you think?

@mjac0bs mjac0bs added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 22, 2024
@hana-linode hana-linode added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 22, 2024
@AzureLatte AzureLatte merged commit 4f29734 into linode:develop Aug 26, 2024
19 checks passed
@AzureLatte AzureLatte deleted the M3-7479 branch August 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants