-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8398] - Generate firewall dialog #10770
upcoming: [M3-8398] - Generate firewall dialog #10770
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/GenerateFirewallDialog.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/GenerateFirewallDialog.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
Good point. Let me follow up with UX about this Edit: UX confirmed button should be moved to the right. |
packages/manager/src/components/GenerateFirewallDialog/GenerateFirewallDialog.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Firewalls/FirewallDetail/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work getting this completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the loader can be improved on the second generation of a FW, but otherwise this looks good. nice job!
e18976f
to
e3e5015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice job on this one
Description 📝
Implements the generate firewall dialog, which guides users through the process of generating a compliant firewall from a template.
Changes 🔄
api-v4
packageGenerateFirewallDialog
component that steps users through generating a firewall from a templateuseCreateFirewallFromTemplate
which exposes a script to fetch firewall templates, select a label and create the new firewallFirewallLanding
and Linode create flowsreplaceNewlinesWithLineBreaks
to handle rendering multi-line content from LDTarget release date 🗓️
8/19
Preview 📷
See the internal ticket.
How to test 🧪
See the internal ticket.
As an Author I have considered 🤔
Check all that apply