Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8398] - Generate firewall dialog #10770

Merged

Conversation

hkhalil-akamai
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai commented Aug 12, 2024

Description 📝

Implements the generate firewall dialog, which guides users through the process of generating a compliant firewall from a template.

Changes 🔄

  • New firewall template endpoints to api-v4 package
    • Add RQ hook for firewall templates
  • New GenerateFirewallDialog component that steps users through generating a firewall from a template
    • Add hook useCreateFirewallFromTemplate which exposes a script to fetch firewall templates, select a label and create the new firewall
    • Implement dialog in FirewallLanding and Linode create flows
    • Unit tests
  • New utility replaceNewlinesWithLineBreaks to handle rendering multi-line content from LD
    • Unit tests

Target release date 🗓️

8/19

Preview 📷

See the internal ticket.

How to test 🧪

See the internal ticket.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hkhalil-akamai hkhalil-akamai self-assigned this Aug 12, 2024
@hkhalil-akamai hkhalil-akamai marked this pull request as ready for review August 13, 2024 16:28
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner August 13, 2024 16:28
@hkhalil-akamai hkhalil-akamai requested review from bnussman-akamai and removed request for a team August 13, 2024 16:28
Copy link

github-actions bot commented Aug 13, 2024

Coverage Report:
Base Coverage: 82.46%
Current Coverage: 82.62%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an UI/UX standpoint, I'm not sure how I feel about putting the buttons on the left side. I feel like they should be on the right to be consistent with our patterns.

Screenshot 2024-08-13 at 1 22 08 PM

@hkhalil-akamai
Copy link
Contributor Author

hkhalil-akamai commented Aug 13, 2024

From an UI/UX standpoint, I'm not sure how I feel about putting the buttons on the left side. I feel like they should be on the right to be consistent with our patterns.

Good point. Let me follow up with UX about this

Edit: UX confirmed button should be moved to the right.

Copy link
Contributor

@carrillo-erik carrillo-erik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work getting this completed.

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the loader can be improved on the second generation of a FW, but otherwise this looks good. nice job!

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 15, 2024
@hkhalil-akamai hkhalil-akamai force-pushed the M3-8398-firewall-generate-dialog branch from e18976f to e3e5015 Compare August 15, 2024 14:37
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice job on this one

packages/api-v4/src/firewalls/firewalls.ts Outdated Show resolved Hide resolved
@hkhalil-akamai hkhalil-akamai merged commit 834c665 into linode:develop Aug 15, 2024
19 checks passed
@hkhalil-akamai hkhalil-akamai deleted the M3-8398-firewall-generate-dialog branch August 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Secure VMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants