Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix EditImageDrawer.test.tsx Unit Test Flake #10759

Merged
merged 3 commits into from
Aug 8, 2024
Merged

test: Fix EditImageDrawer.test.tsx Unit Test Flake #10759

merged 3 commits into from
Aug 8, 2024

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Aug 7, 2024 •
edited
Loading

Description 📝

Fixes unit test flake with EditImageDrawer.test.tsx by awaiting the userEvent.type call ⌛

Preview 📷

This is the flake I am trying to fix
Screenshot 2024-08-07 at 10 07 30 AM

How to test 🧪

  • Verify Github Actions passes ✅
  • Run the test locally a few times and verify it consistently succeeds ✅
repeat 10 yarn test EditImageDrawer

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Unit tests Improves unit test coverage label Aug 7, 2024
@bnussman-akamai bnussman-akamai self-assigned this Aug 7, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner August 7, 2024 14:17
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and AzureLatte and removed request for a team August 7, 2024 14:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 82.43%
Current Coverage: 82.43%

AzureLatte
AzureLatte approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jdamore-linode
jdamore-linode approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Ran the test repeatedly locally and didn't see any failures, and CI has passed three times in a row now. Thanks @bnussman-akamai!

@bnussman-akamai bnussman-akamai merged commit 076caba into linode:develop Aug 8, 2024
19 checks passed
This was referenced Aug 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureLatte AzureLatte AzureLatte approved these changes

@jdamore-linode jdamore-linode jdamore-linode approved these changes

Assignees

@bnussman-akamai bnussman-akamai

Labels
Unit tests Improves unit test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @jdamore-linode @AzureLatte @bnussman