Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8366] – DiskEncryption slight refactor & renaming #10735

Conversation

dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Jul 31, 2024

Description πŸ“

Lay the ground work for Encryption (formerly DiskEncryption) component to be reusable for Volume Encryption.

Changes πŸ”„

  • DiskEncryption --> Encryption directory name change, DiskEncryption.tsx --> Encryption.tsx component name change, & associated import updates
  • Minor refactors in Encryption.tsx to make it more easily reusable for Volume Encryption (not hardcoding "Disk Encryption", etc.)

Target release date πŸ—“οΈ

8/5/24

How to test πŸ§ͺ

The primary concern at this juncture given the refactoring of Encryption.tsx is ensuring no regressions for LDE in the Linode Create flow and Linode Rebuild dialog.

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

…mport paths accordingly; slight refactors in Encryption.tsx to make it more flexible for upcoming Volumes use case
@dwiley-akamai dwiley-akamai added the Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption label Jul 31, 2024
@dwiley-akamai dwiley-akamai self-assigned this Jul 31, 2024
@dwiley-akamai dwiley-akamai requested review from a team as code owners July 31, 2024 18:30
@dwiley-akamai dwiley-akamai requested review from AzureLatte, bnussman-akamai and hkhalil-akamai and removed request for a team July 31, 2024 18:30
Copy link

github-actions bot commented Jul 31, 2024

Coverage Report: βœ…
Base Coverage: 82.44%
Current Coverage: 82.44%

Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all test failures are related with Volumes, which were not caused by these changes.

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Aug 1, 2024
@dwiley-akamai dwiley-akamai merged commit 2741103 into linode:develop Aug 1, 2024
18 of 19 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8366-refactor-diskencryption-component branch August 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants