test: [M3-8319] - Add CM Logout test #10733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Looks great @AzureLatte! Posted a couple little suggestions, but the one about the URL assertion is the only one that matters that much -- approved pending that!
Comment on lines
20
to
24
| cy.findByTestId('nav-group-profile').click(); | ||
| cy.findByTestId('menu-item-Log Out') | ||
| .should('be.visible') | ||
| .should('be.enabled') | ||
| .click(); |
There was a problem hiding this comment.
nit: we could make this a little more idiomatic using the userMenu and userMenuButton UI helpers
Suggested change
| cy.findByTestId('nav-group-profile').click(); | |
| cy.findByTestId('menu-item-Log Out') | |
| .should('be.visible') | |
| .should('be.enabled') | |
| .click(); | |
| ui.userMenuButton | |
| .find() | |
| .click(); | |
| ui.userMenu | |
| .find() | |
| .should('be.visible') | |
| .within(() => { | |
| cy.findByText('Log Out').should('be.visible').click(); | |
| }); |
Comment on lines
28
to
29
| cy.visit('/login'); | ||
| cy.url().should('endWith', `/login`); |
There was a problem hiding this comment.
Suggested change
| cy.visit('/login'); | |
| cy.url().should('endWith', `/login`); | |
| cy.visit('/'); | |
| cy.url().should('startWith', `${LOGIN_ROOT}/login`); |
Otherwise the URL assertion will immediately pass without waiting for Cloud to actually redirect to the Login application since both pages end with /login
There was a problem hiding this comment.
Updated, thank you!
jaalah-akamai
approved these changes
Jul 31, 2024
|
Volumn failure has been fixed in #10728 |
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Create a Cloud Manager end-to-end test which tests the Cloud Manager logout flow. This will confirm that Cloud Manager log out functionality works as expected and implicitly confirm that the login application is up, which is useful from a synthetic testing perspective.
Changes 🔄
How to test 🧪
As an Author I have considered 🤔
Check all that apply