-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8215] - Hide monthly network transfer section for distributed regions #10714
upcoming: [M3-8215] - Hide monthly network transfer section for distributed regions #10714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/.changeset/pr-10714-upcoming-features-1721926239567.md
Outdated
Show resolved
Hide resolved
...res/Linodes/LinodesDetail/LinodeNetworking/NetworkingSummaryPanel/NetworkingSummaryPanel.tsx
Outdated
Show resolved
Hide resolved
…239567.md Co-authored-by: Mariah Jacobs <[email protected]>
@mjac0bs Good catch, I asked Kendall and he said there was some initial discussion to completely redesign the network transfer UI |
Coverage Report: ✅ |
A complete redesign sounds like it may take some time to actually get designed and implemented - though I'm in agreement that it should happen; I know customer support gets questions about usage and things not being clear. But in the meantime, what do we think about saying "your devices' core regions" or something like that in the tooltip? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
const hideNetworkTransfer = | ||
isGeckoGAEnabled && linode.site_type === 'distributed'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we simplify this to
const hideNetworkTransfer = | |
isGeckoGAEnabled && linode.site_type === 'distributed'; | |
const showNetworkTransfer = linode.site_type === 'core'; |
So that the ternary below could be replaced with a &&
Description 📝
Distributed compute instances have no transfer pool, so the Monthly Network Transfer section is irrelevant. This PR hides that section and expands the Network Transfer History chart to occupy the space.
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
new-dc-testing
,edge_testing
andedge_compute
customer tagsVerification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply