upcoming: [DI-19818] - Added line graph to CloudPulse widgets for different metrics

[nikhagra-akamai]

Description 📝

Line graph component is added in cloud pulse widget to showcase data for different metrics.

Changes 🔄

List any change relevant to the reviewer.

1. CloudPulseLineGraph is added in the cloud pulse widget for metrics
2. LineGraph component is modified for full width legends as it was restricting to 85% width
3. Widget color palette is added for predefined colors in graph
4. Necessary type definitions are added to support metrics data
5. Added the metrics api call outside api-v4

Target release date 🗓️

2nd August 2024

Preview 📷

Include a screenshot or screen recording of the change

💡 Use <video src="" /> tag when including recordings in table.

Before	After

How to test 🧪

1. Enable mock services as some endpoints are not ready to use.
2. Graph will be populated with dummy data so you can see the visualization & tool tips.

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[github-actions]

Coverage Report: ✅
Base Coverage: 82.43%
Current Coverage: 82.45%

[carrillo-erik]

Left some initial feedback to be addressed. I'll continue to review but this should give you a starting point. Reach out if you have questions.

[nikhagra-akamai]

Left some initial feedback to be addressed. I'll continue to review but this should give you a starting point. Reach out if you have questions.

Sure thanks for comments, I'll addressed them and also put bigger logic into a util file and reduce the component size

[venkymano-akamai]

LGTM

[jaalah-akamai]

There seems to be a lot of jankiness when you change values for the charts, I'm not sure if that's because we're dealing with mocks or if it's due to multiple re-renderings. It's just something to keep an eye on as development progresses 👍

[jaalah-akamai]

Approving pending changes request from Banks

[jaalah-akamai]

Looks like you have a test failure for objectStorage/access-key.e2e.spec.ts try running yarn cy:run -s cypress/e2e/core/objectStorage/access-key.e2e.spec.ts

[jaalah-akamai]

@carrillo-erik this should be ready for another pass 👍

[nikhagra-akamai]

Looks like you have a test failure for objectStorage/access-key.e2e.spec.ts try running yarn cy:run -s cypress/e2e/core/objectStorage/access-key.e2e.spec.ts

@jaalah-akamai it seems some other test is failing as it doesn't belong to ACLP

[bnussman-akamai]

I highly recommend that the CloudPulse use recharts instead of chart.js

[nikhagra-akamai]

I highly recommend that the CloudPulse use recharts instead of chart.js

We have already discussed regarding this & for now we can move with chart.js for our beta release.
FYI conversation : https://linode.slack.com/archives/C4V05M8TS/p1720592089825549

[jdamore-linode]

@nikhagra Could you merge in the latest changes from develop? That should resolve the test failures

[nikhagra-akamai]

@nikhagra Could you merge in the latest changes from develop? That should resolve the test failures

@jdamore-linode updated from latest dev branch

[bnussman-akamai]

I'm aware of that Slack discussion, but I don't agree with the outcome. It's just creating more work for us later. @nikhagra

[kmuddapo]

I highly recommend that the CloudPulse use recharts instead of chart.js

Its in the radar already post discussion on the slack , we will be migrating it post beta asap. Hope this shouldn't be a showstopper for this PR and beta which we have a very tight-timeline of 2 more weeks only for dev integrations with service owners. Thanks!!

[kmuddapo]

Thanks!! @bnussman-akamai for the approvals. Can this request be merged now please?

[nikhagra-akamai]

@jaalah-akamai @jdamore-linode @bnussman-akamai I've marked marked all the conversations as resolved but still it says merging blocked because of requested changes. Could you please check and merge