Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-6901, M3-6918] - Replace react-select with Autocomplete in Domains #10693

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Jul 18, 2024

Description 📝

We want to get rid of our dependency on react-select for accessibility reasons and to consolidate our usage of third-party libraries.

Changes 🔄

List any change relevant to the reviewer.

  • Replace react-select with Autocomplete component within the Domains feature.

Target release date 🗓️

22nd July, 2024

How to test 🧪

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai requested a review from a team as a code owner July 18, 2024 07:21
@pmakode-akamai pmakode-akamai requested review from jdamore-linode and carrillo-erik and removed request for a team July 18, 2024 07:21
@pmakode-akamai pmakode-akamai self-assigned this Jul 18, 2024
@pmakode-akamai pmakode-akamai force-pushed the M3-6918-replace-select-with-autocomplete-in-domains branch from 3f1cb39 to 034d0f9 Compare July 18, 2024 07:45
Copy link

github-actions bot commented Jul 18, 2024

Coverage Report:
Base Coverage: 82.42%
Current Coverage: 82.42%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Confirmed all selects work as expected.

@pmakode-akamai pmakode-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Jul 19, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 22, 2024
@pmakode-akamai pmakode-akamai merged commit eb17f61 into linode:develop Jul 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants