-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-8327] - Placement Groups General Availability API/UI updates #10651
Conversation
size: 6, | ||
chart_type: 'area', | ||
unit: 'OPS', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are just linting changes
"@linode/api-v4": Changed | ||
--- | ||
|
||
Breaking: change Placement Group `is_strict` to `placement_group_policy` ([#10651](https://github.com/linode/manager/pull/10651)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnwcallahan please let me know your thoughts about those. They are a pretty important part of communicating breaking changes to our customers. To that effect I added an APIv4 changeset for each change since both are breaking. Open to suggestions on the content.
Coverage Report: ✅ |
…`placement_group_type`
…cement_group_policy`
export const PlacementGroupsAffinityTypeEnforcementRadioGroup = ( | ||
props: Props | ||
) => { | ||
const ariaIdentifier = 'placement-group-policy-radio-group'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick: consider moving this const
to the constants.ts
in the same directory.
I've reviewed the changes, a good portion of them are just changing value names or strings to reflect the new copy. I tested the common workflows in |
@carrillo-erik @jdamore-linode @AzureLatte can i get reviews/approvals for this one? been open for a week now, and it's a crucial PR to go along a breaking production API change so it needs to make the cut for the 7/17 release branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't find any issues when testing against dev ✅
Description 📝
Warning
This PR brings breaking changes to Cloud Manager, awaiting a matching APIv4 update to be released the same day
In preparation for Placement Group General Availability, the product team has identified needed breaking changes to APIv4 and Cloud Manager to help our users understand and use the feature more efficiently. As a result, the following changes have been implemented in preparation of a coordinated release on 7/22
Changes 🔄
APIv4:
affinity_type
withplacement_group_type
is_strict
withplacement_group_policy
- enum('strict', 'flexible')Cloud Manager:
Target release date 🗓️
Caution
7/22/2024
Preview 📷
How to test 🧪
Prerequisites
This PR will break current functionality (create PG) and display missing data in production.
As a result, it must be tested either in alpha or with MSW turned on.
Verification steps
As an Author I have considered 🤔
Check all that apply