-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-8322] - Add Design Update Global Notification Banner #10640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ✅
Banner contents & dismissibility ✅
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Banner looks good ✅
const flags = useFlags(); | ||
const designUpdateFlag = flags.cloudManagerDesignUpdatesBanner; | ||
|
||
if (!designUpdateFlag || !designUpdateFlag.enabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is enabled
needed if this is a toggleable flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is our standard now for JSON flags now.
return ( | ||
<DismissibleBanner preferenceKey={key} variant="info"> | ||
<Typography variant="body2"> | ||
We are improving the Cloud Manager experience for our users.{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this text be in the flag in case we need to change it?
If I were a Linode customer and saw We are improving the Cloud Manager experience for our users.
, I'd get triggered because I expect the Cloud Manager experience to be improving at all times. I feel like as this sits currently, we're telling users we're doing the bare minimum.
Maybe it should say We are improving Cloud Manager's visual experience for our users.
to hint at the design changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the the copy that was provided and vetted by our marketing folks, so I am going to leave it at that.
Description 📝
This PR adds a new dismissible banner for the upcoming design/token updates.
The banner needs to be a little dynamic, featuring the two following variations:
The key is meant to give us the ability to re-introduce the banner for future updates (since it is generic) when people have dismissed it already.
Changes 🔄
Target release date 🗓️
7/8 2024
Preview 📷
How to test 🧪
The flag is currently only enabled in
development
Verification steps
Cloud Manager Design Updates Banner
configuration in LDAs an Author I have considered 🤔
Check all that apply