Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8322] - Add Design Update Global Notification Banner #10640

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Jul 2, 2024

Description 📝

This PR adds a new dismissible banner for the upcoming design/token updates.

The banner needs to be a little dynamic, featuring the two following variations:

{
  "enabled": true,
  "key": "design-tokens-7-9-2024",
  "link": "https://www.linode.com/docs/guides/an-overview-of-the-cloud-manager"
}
{
  "enabled": false,
  "key": "design-tokens-7-9-2024",
  "link": "https://www.linode.com/docs/guides/an-overview-of-the-cloud-manager"
}

The key is meant to give us the ability to re-introduce the banner for future updates (since it is generic) when people have dismissed it already.

Changes 🔄

  • Create new feature flag
  • Implement banner

Target release date 🗓️

7/8 2024

Preview 📷

Screenshot 2024-07-03 at 12 39 28

How to test 🧪

The flag is currently only enabled in development

Verification steps

  • Verify Cloud Manager Design Updates Banner configuration in LD
  • Pull code locally and confirm banner + linkage + dismissible state

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Jul 2, 2024
@abailly-akamai abailly-akamai changed the title change: [M3-8322] - Add Theme/Tokens update Global Notification Banner change: [M3-8322] - Add Design Update Global Notification Banner Jul 3, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review July 3, 2024 17:08
@abailly-akamai abailly-akamai requested a review from a team as a code owner July 3, 2024 17:08
@abailly-akamai abailly-akamai requested review from carrillo-erik and jaalah-akamai and removed request for a team July 3, 2024 17:08
@dwiley-akamai dwiley-akamai self-requested a review July 3, 2024 17:23
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ✅
Banner contents & dismissibility ✅

Copy link

github-actions bot commented Jul 3, 2024

Coverage Report:
Base Coverage: 82.18%
Current Coverage: 82.18%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Banner looks good ✅

const flags = useFlags();
const designUpdateFlag = flags.cloudManagerDesignUpdatesBanner;

if (!designUpdateFlag || !designUpdateFlag.enabled) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is enabled needed if this is a toggleable flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our standard now for JSON flags now.

return (
<DismissibleBanner preferenceKey={key} variant="info">
<Typography variant="body2">
We are improving the Cloud Manager experience for our users.{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this text be in the flag in case we need to change it?

If I were a Linode customer and saw We are improving the Cloud Manager experience for our users., I'd get triggered because I expect the Cloud Manager experience to be improving at all times. I feel like as this sits currently, we're telling users we're doing the bare minimum.

Maybe it should say We are improving Cloud Manager's visual experience for our users. to hint at the design changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the the copy that was provided and vetted by our marketing folks, so I am going to leave it at that.

@abailly-akamai abailly-akamai merged commit 4a452db into linode:develop Jul 3, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants