Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7684] - Keep Create Volumes Page Error Notification Position Consistent #10632

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Jul 1, 2024

Description 📝

Keeping the Create Volumes Page error notification position consistent with other tabs like NodeBalancers.

Changes 🔄

  • For restricted users:
    • The position of error notification has been moved from inside the box to outside, which is now consistent with other tabs like NodeBalancers.
    • Used getRestrictedResourceText utility to show a Notice / error notification message.

Target release date 🗓️

July 8th, 2024

Preview 📷

Before After
Screenshot 2024-07-01 at 11 21 53 PM Screenshot 2024-07-01 at 11 48 30 PM

How to test 🧪

Prerequisites

(How to setup test environment)

  • Log in with a restricted user account (read-only access) and go to the Create Volumes Page via volumes/create route directly from you browser.

Reproduction steps

  • Observe as restricted user, error notification shows out of the box (not inside as before) and you cannot create Volumes.

Verification steps

  • As a restricted user, compare Create Volumes Page (route: volumes/create) with Create NodeBalancers Page (route: nodebalancers/create) to ensure consistency.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai requested a review from a team as a code owner July 1, 2024 19:06
@pmakode-akamai pmakode-akamai requested review from jdamore-linode and cpathipa and removed request for a team July 1, 2024 19:06
Copy link

github-actions bot commented Jul 1, 2024

Coverage Report:
Base Coverage: 82.18%
Current Coverage: 82.18%

@pmakode-akamai pmakode-akamai changed the title change: [M3-7684] - Keep Volumes Create Page Error Notification Position Consistent change: [M3-7684] - Keep Create Volumes Page Error Notification Position Consistent Jul 1, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Purvesh! I confirmed the permissions error displays as described for a restricted user and left a comment about the other error messages.

image

Two small notes:

  • Can you add a changeset for this PR? (yarn changeset) and describe the change? This will get incorporated into our changelog for our next release.

  • I just updated the target release date in this PR's description. We release every other week on Mondays, which makes our next release on Monday, July 8th. (If you're looking for our release schedule in our internal docs and haven't found it, I can send it your way.)

packages/manager/src/features/Volumes/VolumeCreate.tsx Outdated Show resolved Hide resolved
@pmakode-akamai pmakode-akamai force-pushed the M3-7684-keep-volumes-create-page-error-notif-position-consistent branch from 2bcd568 to aae1a37 Compare July 2, 2024 05:49
@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jul 2, 2024
@pmakode-akamai pmakode-akamai force-pushed the M3-7684-keep-volumes-create-page-error-notif-position-consistent branch from a75c156 to f07a8da Compare July 2, 2024 17:34
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! Volumes Relating to Volumes (aka Block Storage) and removed Add'tl Approval Needed Waiting on another approval! labels Jul 2, 2024
@mjac0bs mjac0bs added the Restricted User Access Improve UX surrounding restricted access to features label Jul 2, 2024
@pmakode-akamai pmakode-akamai merged commit e9b23fd into linode:develop Jul 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Restricted User Access Improve UX surrounding restricted access to features Volumes Relating to Volumes (aka Block Storage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants