-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7684] - Keep Create Volumes Page Error Notification Position Consistent #10632
change: [M3-7684] - Keep Create Volumes Page Error Notification Position Consistent #10632
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Purvesh! I confirmed the permissions error displays as described for a restricted user and left a comment about the other error messages.
Two small notes:
-
Can you add a changeset for this PR? (
yarn changeset
) and describe the change? This will get incorporated into our changelog for our next release. -
I just updated the target release date in this PR's description. We release every other week on Mondays, which makes our next release on Monday, July 8th. (If you're looking for our release schedule in our internal docs and haven't found it, I can send it your way.)
2bcd568
to
aae1a37
Compare
…he box to outside & used getRestrictedResourceText utility for the Notice
a75c156
to
f07a8da
Compare
Description 📝
Keeping the Create Volumes Page error notification position consistent with other tabs like NodeBalancers.
Changes 🔄
getRestrictedResourceText
utility to show a Notice / error notification message.Target release date 🗓️
July 8th, 2024
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply