Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-8066] - Debounce the Linode Create v2 VLANSelect #10628

Merged
merged 4 commits into from
Jul 2, 2024
Merged

upcoming: [M3-8066] - Debounce the Linode Create v2 VLANSelect #10628

merged 4 commits into from
Jul 2, 2024

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jul 1, 2024 •
edited
Loading

Description 📝

  • Adds debouncing the VLANSelect created for and used on Linode Create v2 ⏲️
  • Adds a new useDebouncedValue hook to make this easy
    • Let me know if you know of a better way 💡

Preview 📷

Before After
Screen.Recording.2024-07-01.at.11.04.13.AM.mov
Screen.Recording.2024-07-01.at.11.03.21.AM.mov

How to test 🧪

Prerequisites

  • Turn on Linode Create v2

Verification steps

  • Verify that the API search performed by the VLANSelect is debounced and works as expected

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Jul 1, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner July 1, 2024 15:06
@bnussman-akamai bnussman-akamai requested review from hana-linode and AzureLatte and removed request for a team July 1, 2024 15:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 82.18%
Current Coverage: 82.2%

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Jul 1, 2024
AzureLatte
AzureLatte approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 2, 2024
@bnussman-akamai bnussman-akamai merged commit 921c863 into linode:develop Jul 2, 2024
19 checks passed
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Jul 3, 2024
@bnussman-akamai @bnussman @nikhagra-akamai
upcoming: [M3-8066] - Debounce the Linode Create v2 VLANSelect (lin…
5979c3f 
…ode#10628)

* debounce input value so less requests are made

* add unit test

* changeset and improve test name

* add a default debounce of `500` ms

---------

Co-authored-by: Banks Nussman <[email protected]>
This was referenced Jul 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@AzureLatte AzureLatte AzureLatte approved these changes

@hana-linode hana-linode Awaiting requested review from hana-linode hana-linode is a code owner automatically assigned from linode/frontend

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Linode Create Refactor Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @jaalah-akamai @AzureLatte @bnussman