Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7684] - Disable Create Volume button with tooltiptext on Landing Page for restricted users #10627

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Jul 1, 2024

Description 📝

To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.

Here, we are restricting users from creating new Volume when they do not have access or have read only access.

Changes 🔄

  • For restricted users:
    • Disabled Create Volume Button on the Landing Page

Target release date 🗓️

July 8th, 2024

Preview 📷

Before After
Screenshot 2024-07-01 at 8 30 45 PM Screenshot 2024-07-01 at 8 36 41 PM

How to test 🧪

Prerequisites

(How to setup test environment)

  • Log into two accounts side by side:
    • An unrestricted admin user account: full access
    • A restricted user account (use Incognito for this)
      - Start with Read Only for everything

Reproduction steps

  • Landing:
    • Observe as restricted user, notice shows and you cannot create Volumes

Verification steps

  • After changes, observe tooltips are tailored to the action.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai requested a review from a team as a code owner July 1, 2024 14:46
@pmakode-akamai pmakode-akamai requested review from jdamore-linode and cpathipa and removed request for a team July 1, 2024 14:46
@pmakode-akamai pmakode-akamai changed the title feat: [M3-7684] - Disable Create Volume button with tooltiptext on La… feat: [M3-7684] - Disable Create Volume button with tooltiptext on Landing Page for restricted users Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

Coverage Report:
Base Coverage: 82.18%
Current Coverage: 82.18%

@bnussman-akamai bnussman-akamai added the Volumes Relating to Volumes (aka Block Storage) label Jul 1, 2024
@pmakode-akamai pmakode-akamai force-pushed the M3-7684-disable-landing-page-create-volume-button-for-restricted-users branch from aa7434e to 1d16f5f Compare July 2, 2024 07:31
@pmakode-akamai pmakode-akamai force-pushed the M3-7684-disable-landing-page-create-volume-button-for-restricted-users branch from 8bdc560 to bae640c Compare July 2, 2024 15:16
@jaalah-akamai jaalah-akamai added the Restricted User Access Improve UX surrounding restricted access to features label Jul 2, 2024
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the small and precise change - this looks good.

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Jul 2, 2024
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pmakode-akamai! changes LGTM.

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 2, 2024
@pmakode-akamai pmakode-akamai merged commit 4801962 into linode:develop Jul 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Restricted User Access Improve UX surrounding restricted access to features Volumes Relating to Volumes (aka Block Storage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants