test: Unit test coverage - HostNameTableCell #10596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return HttpResponse.json(makeResourcePage([region])); | ||
| }) | ||
| ); | ||
| const { findByText } = renderWithThemeAndHookFormContext({ |
There was a problem hiding this comment.
Does HostNameTableCell use React Hook form? If not, we can probably just use renderWithTheme
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
Jun 20, 2024
|
|
||
| import { HostNameTableCell } from './HostNameTableCell'; | ||
|
|
||
| const storageKeyData = { |
There was a problem hiding this comment.
there isn't a factory for this but it should make one cause this isn't typed at all and it could make the test code more readable
There was a problem hiding this comment.
Agreed, replaced with the factory objectStorageKeyFactory. - 26a539c
...ges/manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyTable/HostNameTableCell.tsx
Outdated
Show resolved
Hide resolved
…ccessKeyTable/HostNameTableCell.tsx Co-authored-by: Alban Bailly <[email protected]>
abailly-akamai
approved these changes
Jun 20, 2024
| it('should render "None" when there are no regions', () => { | ||
| const { getByText } = renderWithTheme( | ||
| <HostNameTableCell | ||
| storageKeyData={{ |
There was a problem hiding this comment.
nit: you could use the factory here as well.
bnussman-akamai
approved these changes
Jun 20, 2024
...ges/manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyTable/HostNameTableCell.tsx
Outdated
Show resolved
Hide resolved
…ccessKeyTable/HostNameTableCell.tsx Co-authored-by: Banks Nussman <[email protected]>
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This a followup of #10555 - Adds unit test coverage for HostNameTableCell.
Target release date 🗓️
6/24
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply