change: [M3-8242] - Update TypeScript to latest #10573
Conversation
|
Coverage Report: ✅ |
| @@ -227,7 +227,7 @@ export const printInvoice = async ( | |||
| unit: 'px', | |||
| }); | |||
|
|
|||
| const convertedInvoiceDate = invoice.date && dateConversion(invoice.date); | |||
| const convertedInvoiceDate = dateConversion(invoice.date); | |||
There was a problem hiding this comment.
It's amazing this passed typechecking previously 😳
| export const SortableTableHead = <T extends unknown>( | ||
| props: SortableTableHeadProps<T> | ||
| ) => { | ||
| export const SortableTableHead = <T,>(props: SortableTableHeadProps<T>) => { |
There was a problem hiding this comment.
eslint didn't like extends unknown which makes sense to me because extends unknown is useless
| @@ -32,6 +32,7 @@ export const RouteAccordion = ({ configIndex, route, routeIndex }: Props) => { | |||
| sx={{ backgroundColor: '#f4f5f6', paddingLeft: 1, paddingRight: 1.4 }} | |||
| > | |||
| {/* TODO ACLB: Implement RulesTable */} | |||
| <>Todo</> | |||
There was a problem hiding this comment.
The Accordion props types requires children. This is fine because this code isn't customer facing.
There was a problem hiding this comment.
I cleaned up some old Redux code because it isn't referenced elsewhere in the app and contained some eslint errors
There was a problem hiding this comment.
Beautiful! Love to see dead code removed from the project.
| "ignoreDeprecations": "5.0", | ||
| "suppressImplicitAnyIndexErrors": true, |
There was a problem hiding this comment.
suppressImplicitAnyIndexErrors will be deprecated in v5.5 so the next PR will be removing these two lines and fixing all 250 of the errors this causes 😬
There was a problem hiding this comment.
Sounds good. This will also be an improvement for type safety!
| "ignoreDeprecations": "5.0", | ||
| "suppressImplicitAnyIndexErrors": true, |
There was a problem hiding this comment.
Sounds good. This will also be an improvement for type safety!
| @@ -34,73 +34,6 @@ export type ThunkDispatch = _ThunkDispatch<ApplicationState, undefined, Action>; | |||
|
|
|||
| export type MapState<S, O> = _MapStateToProps<S, O, ApplicationState>; | |||
|
|
|||
| export interface HasStringID { | |||
There was a problem hiding this comment.
@bnussman Thanks for keeping the codebase clean 👍
* update typescript to latest and ignore deprecations * Added changeset: Update TypeScript to latest * fix eslint errors and remove unused code --------- Co-authored-by: Banks Nussman <[email protected]>
Description 📝
Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' insteadError while loading rule '@typescript-eslint/no-loss-of-precision': @typescript-eslint/no-loss-of-precision requires at least ESLint v7.1.0Why ❓
How to test 🧪
lintGithub Actions jobs passtypecheckGithub Actions job passesAs an Author I have considered 🤔