-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8232] - Query Key Factory for Firewalls #10568
refactor: [M3-8232] - Query Key Factory for Firewalls #10568
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean up and cache updates look like they're happening as expected. Confirmed the general firewall create/delete, enable/disable, and add/remove rules. NodeBalancer and Linodes assigned updated accordingly. Also confirmed that unassigning a Firewall from a NB or Linode would update as expected on FW pages. Once tests pass, this should be good to go. 🚀
Description 📝
Preview 📷
Note
No UI changes expected
How to test 🧪
As an Author I have considered 🤔