Escape queueName and vhostName in RabbitMQ Scaler before use them in query string (bug fix)
#2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <[email protected]>
…string Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
coderanger
reviewed
Aug 24, 2021
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
|
I have just updated the e2e images and moved from draft to open the PR :) |
Signed-off-by: Jorge Turrado <[email protected]>
queueName and vhostName in RabbitMQ Scaler before use them in query stringqueueName and vhostName in RabbitMQ Scaler before use them in query string (bug fix)
ahmelsayed
approved these changes
Aug 26, 2021
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
… in query string (bug fix) (kedacore#2055) Signed-off-by: nilayasiktoprak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR escapes the values introduced by the user before add them into a query string. These values are the
queueName(main goal) andvhostName. This second one is because the virtual host can contain also escapable values:I update also the e2e test to ensure that it cover the regex use case
This PR is in WIP because I need to wait until this is merged kedacore/test-tools#17
Checklist
Fixes #2054