Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show HashiCorp Vault Address when using 'kubectl get ta' or 'kubectl get cta' #1862

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Show HashiCorp Vault Address when using 'kubectl get ta' or 'kubectl get cta' #1862

merged 3 commits into from
Jun 7, 2021

Conversation

Shubham82
Copy link
Contributor

@Shubham82 Shubham82 commented Jun 4, 2021 •
edited

Signed-off-by: Shubham Kuchhal [email protected]

Add VaultAdress field in TriggerAuthentication and ClusterTriggerAuthentication CRD so on using kubectl get TriggerAuthentication or kubectl get ClusterTriggerAuthentication it would show the Address of HashiCorp Vault.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Changelog has been updated

Fixes #1826

@Shubham82 Shubham82 changed the title Show HashiCorp Vault Address when using Kubectl get ta or kubectl get cta Show HashiCorp Vault Address when using Kubectl get ta or kubectl get cta Jun 4, 2021
@Shubham82 Shubham82 changed the title Show HashiCorp Vault Address when using Kubectl get ta or kubectl get cta Show HashiCorp Vault Address when using 'kubectl get ta' or 'kubectl get cta' Jun 4, 2021
@Shubham82 Shubham82 mentioned this pull request Jun 4, 2021
Closed
@Shubham82
Copy link
Contributor Author

Hi @tomkerkhove @zroubalik
PTAL

tomkerkhove
tomkerkhove approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zroubalik
zroubalik reviewed Jun 4, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you please open another PR for charts, so the CRDs are updated there as well?

https://github.com/kedacore/charts/blob/master/keda/templates/05-crd-triggerauthentications.keda.sh.yaml

https://github.com/kedacore/charts/blob/master/keda/templates/02-crd-clustertriggerauthentications.yaml

@zroubalik
Copy link
Member

And please update changelog as well :)

@Shubham82
Update the Changelog.
760d078 
Signed-off-by: Shubham Kuchhal <[email protected]>
@Shubham82
Copy link
Contributor Author

And please update changelog as well :)

Addressed the comment

@Shubham82
Copy link
Contributor Author

Looking good, could you please open another PR for charts, so the CRDs are updated there as well?

https://github.com/kedacore/charts/blob/master/keda/templates/05-crd-triggerauthentications.keda.sh.yaml

https://github.com/kedacore/charts/blob/master/keda/templates/02-crd-clustertriggerauthentications.yaml

Sure I will soon create a PR for it also.

@Shubham82
Correct the Changelog.
8e26174 
Signed-off-by: Shubham Kuchhal <[email protected]>
@Shubham82 Shubham82 mentioned this pull request Jun 5, 2021
Merged
1 task
@Shubham82
Copy link
Contributor Author

Looking good, could you please open another PR for charts, so the CRDs are updated there as well?

https://github.com/kedacore/charts/blob/master/keda/templates/05-crd-triggerauthentications.keda.sh.yaml

https://github.com/kedacore/charts/blob/master/keda/templates/02-crd-clustertriggerauthentications.yaml

Done! kedacore/charts#164

zroubalik
zroubalik approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Shubham82 !

@zroubalik zroubalik merged commit d75dbee into kedacore:main Jun 7, 2021
@zroubalik zroubalik added this to the v2.4.0 milestone Jul 14, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@Shubham82 @nilayasiktoprak
Show HashiCorp Vault Address when using 'kubectl get ta' or 'kubectl …
5d3d198 
…get cta' (kedacore#1862)

Signed-off-by: Shubham Kuchhal <[email protected]>
Signed-off-by: nilayasiktoprak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Provide information concerning HashiCorp Vault in CRD
3 participants
@Shubham82 @zroubalik @tomkerkhove