Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus metrics related to ScaledObject readiness #5663

Closed
hy00nc opened this issue Apr 5, 2024 · 4 comments · Fixed by #5664
Closed

Add Prometheus metrics related to ScaledObject readiness #5663

hy00nc opened this issue Apr 5, 2024 · 4 comments · Fixed by #5664
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@hy00nc
Copy link

hy00nc commented Apr 5, 2024

Proposal

It'd be good to add a new Prometheus metrics in KEDA operator to monitor ScaledObject readiness, for example keda_scaled_object_ready similar to keda_scaled_object_paused.

Use-Case

This will help us monitor the correctness and readiness of the ScaledObject in the cluster.

Is this a feature you are interested in implementing yourself?

No

Anything else?

I'm requesting this because keda_scaled_object_errors doesn't seem to cover some scaled object errors.
To be specific, when we use Prometheus scaler in the ScaledObject, if we have wrong server address and fail to create the Scaler, keda_scaled_object_errors value does not go up. I needed to have some other metrics to catch this kind of situation.

@hy00nc hy00nc added feature-request All issues for new features that have not been committed to needs-discussion labels Apr 5, 2024
@hy00nc hy00nc changed the title Add Prometheus metrics related to ScaleObject readiness Add Prometheus metrics related to ScaledObject readiness Apr 5, 2024
@JorTurFer
Copy link
Member

Hello,
Would fixing keda_scaled_object_errors be enough? I think that if there is an error we should report it and this is just a bug

@hy00nc
Copy link
Author

hy00nc commented Apr 5, 2024

Hello @JorTurFer, thank you for the reply. If that's the case, fixing the bug works for me.

@JorTurFer
Copy link
Member

I'm checking and I can reproduce the issue, keda_scaled_object_errors doesn't report the value in that case, but in the meantime I can suggest to use keda_scaler_errors as it reports the value correctly. e.g:

keda_scaler_errors{metric="s0-prometheus",namespace="prometheus-test-ns",scaledObject="prometheus-test-so",scaler="prometheusScaler",triggerIndex="0",type="scaledobject"} 6

@hy00nc
Copy link
Author

hy00nc commented Apr 5, 2024

Thanks a lot! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants