Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding EndpointUrl for AWS-related scalers #3337

Closed
barndawe opened this issue Jul 7, 2022 · 4 comments · Fixed by #3779 or kedacore/keda-docs#965
Closed

Allow overriding EndpointUrl for AWS-related scalers #3337

barndawe opened this issue Jul 7, 2022 · 4 comments · Fixed by #3779 or kedacore/keda-docs#965
Labels
aws All issues concerning integration with AWS feature All issues for new features that have been committed to Hacktoberfest help wanted Looking for support from community

Comments

@barndawe
Copy link

barndawe commented Jul 7, 2022

Proposal

AWS Go SDK client allows for passing in an EndpointUrl parameter to override the AWS endpoint url (see Config struct for AWS client. Currently Keda does not allow for specifying this, e.g. for the SQS scaler, so it is not possible to run Keda against anything but full-fat AWS.

Use-Case

Adding the ability to override the EndpointUrl would allow Keda to be pointed at a Localstack SQS queue (https://docs.localstack.cloud/aws/sqs/).

Anything else?

No response

@barndawe barndawe added feature-request All issues for new features that have not been committed to needs-discussion labels Jul 7, 2022
@tomkerkhove tomkerkhove added help wanted Looking for support from community feature All issues for new features that have been committed to aws All issues concerning integration with AWS and removed needs-discussion feature-request All issues for new features that have not been committed to labels Jul 11, 2022
@tomkerkhove
Copy link
Member

Makes sense, are you willing to contribute this?

@aviadlevy
Copy link
Contributor

Makes sense, are you willing to contribute this?

I can take a look if the issue reporter don't want to (I think we can give him few more days to respond)

@yuyuvn
Copy link
Contributor

yuyuvn commented Oct 26, 2022

@aviadlevy

did you start to do it? (or still want to do it?)
It was a few months and I think we don't have any response from reporter...
I can do it if no one going to do

@aviadlevy
Copy link
Contributor

@aviadlevy

did you start to do it? (or still want to do it?)
It was a few months and I think we don't have any response from reporter...
I can do it if no one going to do

I didn't start working on that. Feel free to take it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws All issues concerning integration with AWS feature All issues for new features that have been committed to Hacktoberfest help wanted Looking for support from community
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants