Misc fix #78
Closed
Misc fix #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC provider/libply_la-special.lo
provider/special.c: In function ‘register_special_probes’:
provider/special.c:67:34: warning: ‘base_addr’ may be used uninitialized
in this function [-Wmaybe-uninitialized]
67 | end_offset = (unsigned long)end - base_addr;
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
Sometimes I mistakenly type '$' instead of '@' for maps. But the
error message was not clear and just showed an assertion failure.
Check the type of the node when it assignes to a map like below:
# ply 'kr:vfs_read { $r["bytes"] = quantize(retval); }'
<input>:1:14-25: error: expect map type, but get $r
ERR:-22
wkz
added a commit
that referenced
this pull request
Nov 25, 2021
Small touch-up of the error message.
|
Merged in 3f205bf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is just a couple of small random fixes, The first commit fixes a compiler warning and the second improves an error message when user gave a wrong type for a map expression.
Thanks,
Namhyung