feat: add service_account_email for export subscriptions #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Owl bot is regenerating pull request 1927... |
yoshi-approver
previously approved these changes
May 31, 2024
feywind
previously approved these changes
May 31, 2024
PiperOrigin-RevId: 638641437 Source-Link: googleapis/googleapis@a3016a8 Source-Link: googleapis/googleapis-gen@2001c33 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjAwMWMzMzBhZWU2MmE5ZDRlOGE5ODUyZDhlNWJmMjY2MjgxOGFkNCJ9
e986512
to
6b8094b
Compare
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
yoshi-approver
previously approved these changes
May 31, 2024
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
feywind
approved these changes
Jun 10, 2024
sofisl
added a commit
to googleapis/repo-automation-bots
that referenced
this pull request
Jun 11, 2024
) I noticed in googleapis/nodejs-pubsub#1927 that merge-on-green kept dismissing auto-approve's latest review due to post-processor updates, other commits, etc. Ideally, those commits would retrigger auto-approve to re-review the PR. But there seems to be a race condition where sometimes merge-on-green beats auto-approve to re-approving and dismisses the PR. This fix would allow auto-approve to listen to reviews dismissed, so that it always has a chance to re-review the most recent commit when an `automerge: exact` label has been placed. As part of this work, the pull_request_review.dismissed event needs to access the pr number through [`pull_request.number`](https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request_review), so I had to update this for all the events and make sure the test fixtures had the appropriate number there too. Fixes #5096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 638641437
Source-Link: googleapis/googleapis@a3016a8
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2001c330aee62a9d4e8a9852d8e5bf2662818ad4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjAwMWMzMzBhZWU2MmE5ZDRlOGE5ODUyZDhlNWJmMjY2MjgxOGFkNCJ9