Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): Set default value for BundleByteLimit to 9.5 MiB to avoid payload size limits. #9662

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

gkevinzheng
Copy link
Contributor

Fixes #9479. Verified bugfix on customer code, and added a test that failed for original configuration of 0 and passes on new configuration of 9.5 MiB.

@gkevinzheng gkevinzheng requested a review from bhshkh March 28, 2024 20:55
@gkevinzheng gkevinzheng requested review from a team as code owners March 28, 2024 20:55
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@gkevinzheng gkevinzheng changed the title Set default value for BundleByteLimit to 9.5 MiB to avoid payload size limits. fix(logging): Set default value for BundleByteLimit to 9.5 MiB to avoid payload size limits. Mar 28, 2024
@gkevinzheng gkevinzheng enabled auto-merge (squash) March 28, 2024 21:13
@gkevinzheng gkevinzheng merged commit d5815da into googleapis:main Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging: InvalidArgument desc = Request payload size exceeds the limit: 10485760 bytes.
2 participants