-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spanner: third party dependency exception for github.com/json-iterator/go #9380
Labels
api: spanner
Issues related to the Spanner API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: process
A process-related concern. May include testing, release, or the like.
Comments
There is a significant concern from my point of view with json-iterator dependency due to it's heavy reliance on unsafe and modern-go/reflect2. See golang/go#54766 (comment) for issues that happen from it -- the lucky case is when your compilation or tests fail. |
Thanks @egonelbre for pointing this out, bumping the priority for now. |
elek
added a commit
to elek/google-cloud-go
that referenced
this issue
Apr 11, 2024
This commit removes the JSON support to avoid using json-iter as dependency. See: googleapis#9380
egonelbre
added a commit
to egonelbre/google-cloud-go
that referenced
this issue
May 3, 2024
json-iterator heavily relies on an unmaintained modern-go/reflect2 that pokes at the internals of Go runtime. This was shown to cause failures in golang/go#54766 (comment). Switching to encoding/json does come with a performance penalty. Updates googleapis#9380
rahul2393
pushed a commit
that referenced
this issue
May 3, 2024
json-iterator heavily relies on an unmaintained modern-go/reflect2 that pokes at the internals of Go runtime. This was shown to cause failures in golang/go#54766 (comment). Switching to encoding/json does come with a performance penalty. Updates #9380
egonelbre
added a commit
to egonelbre/google-cloud-go
that referenced
this issue
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the Spanner API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: process
A process-related concern. May include testing, release, or the like.
Module:
spanner
Usage(s):
spanner/value.go
For the time being, it will be exempt from the third party dep check, but please do one of the following:
A. Remove the dependency by switching to a package own directly by Google, handwriting necessary functionality, or using stdlib
B. Justify the exception and ack the risks, maintaining the exception indefinitely
The text was updated successfully, but these errors were encountered: