feat(pubsub): add client ID to initial streaming pull request #10436
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shollyman
approved these changes
Jun 25, 2024
| // clientID to be used across all streaming pull connections that are created. | ||
| // This indicates to the server that any guarantees made for a stream that | ||
| // disconnected will be made for the stream that is created to replace it. | ||
| clientID string |
There was a problem hiding this comment.
are there use cases for making this visible to users?
There was a problem hiding this comment.
In Java the field is marked private, so until that changes, I'm incline to leave as-is.
kamalaboulhosn
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to googleapis/java-pubsub#77, this will improve ordering key affinity and allow Pub/Sub servers to determine if streams are opened from the same subscriber client instance.