Add mandatory IDP referrer check #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgoto
approved these changes
Aug 25, 2022
| @@ -855,6 +855,10 @@ account_id=123&client_id=client1234&nonce=Ct60bD&disclosure_text_shown=true | |||
| ``` | |||
| </div> | |||
|
|
|||
| An [=IDP=] needs to check the referrer to ensure that a malicious [=RP=] does not receive an ID | |||
There was a problem hiding this comment.
Is this a normative conformace requirement to IDPs? If so, is there something like NOTE: that we could use to collect those?
There was a problem hiding this comment.
Anything within a note is non-normative text. So I chose to not put it inside a note.
There was a problem hiding this comment.
Added style per offline discussion.
Co-authored-by: sam goto <[email protected]>
|
ptal |
github-actions bot
added a commit
that referenced
this pull request
Aug 26, 2022
SHA: 3f86d58 Reason: push, by @samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kdenhartog
reviewed
Aug 26, 2022
| @@ -855,6 +861,13 @@ account_id=123&client_id=client1234&nonce=Ct60bD&disclosure_text_shown=true | |||
| ``` | |||
| </div> | |||
|
|
|||
| <div class=idp-normative-text> | |||
| An [=IDP=] needs to check the referrer to ensure that a malicious [=RP=] does not receive an ID | |||
There was a problem hiding this comment.
Nit: using RFC 2119 language here to identify this more clearly as a normative statement would be helpful.
E.g. An IDP MUST check the referrer header matches the expected client id for the RP. If the referrer does not match the client id the IDP MUST reject the request.
Merged
cbiesinger
pushed a commit
to cbiesinger/WebID
that referenced
this pull request
Oct 7, 2022
* Add mandatory IDP referrer check * Update spec/index.bs Co-authored-by: sam goto <[email protected]> * style Co-authored-by: sam goto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325
Preview | Diff