Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass VERSION to engine static builds #70

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Pass VERSION to engine static builds #70

merged 1 commit into from
Dec 12, 2017

Conversation

seemethere
Copy link
Contributor

VERSION file does not exist anymore for moby/moby so we need to
compensate

Signed-off-by: Eli Uriegas [email protected]

@seemethere
Pass VERSION to engine static builds
c411321 
VERSION file does not exist anymore for moby/moby so we need to
compensate

Signed-off-by: Eli Uriegas <[email protected]>
@seemethere seemethere requested a review from a team December 12, 2017 00:08
@seemethere
Copy link
Contributor Author

Can confirm this works:

root@d5693c93984c:/v/static/build/linux/docker# ./dockerd --version
Docker version 17.12.0-ce-rc2, build 5d7e8f3

andrewhsu
andrewhsu approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 453d9a2 into docker:master Dec 12, 2017
@seemethere seemethere mentioned this pull request Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seemethere @andrewhsu