Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce --parallel to limit concurrent engine calls #10030

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 30, 2022

What I did
Introduce --parallel=<int> for user to limit the concurrency during image pulls
could be later applied to other operations, typically build with adequate buildx|kit support for this

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tests are failing due to the wrong default value of the maxConcurrency attribute.
Docs should also be updated 😉

pkg/compose/compose.go Show resolved Hide resolved
@ndeloof ndeloof force-pushed the max_concurrency branch 2 times, most recently from 51b5ee7 to 9bc188b Compare November 30, 2022 13:47
@laurazard
Copy link
Member

Oh nice! This is something that people have asked for for a while, albeit mostly regarding build operations.

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! LGTM 🥳

@ndeloof
Copy link
Contributor Author

ndeloof commented Dec 6, 2022

Build max-parallelism can be controlled, but this takes place on the builder side: https://github.com/docker/buildx/blob/master/docs/guides/resource-limiting.md#max-parallelism

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 77.02% // Head: 77.02% // No change to project coverage 👍

Coverage data is based on head (a0acc20) compared to base (6ed9a79).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10030   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files           2        2           
  Lines         235      235           
=======================================
  Hits          181      181           
  Misses         48       48           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants