-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce --parallel to limit concurrent engine calls #10030
Conversation
37b5d4b
to
cdabc00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think tests are failing due to the wrong default value of the maxConcurrency
attribute.
Docs should also be updated 😉
51b5ee7
to
9bc188b
Compare
Oh nice! This is something that people have asked for for a while, albeit mostly regarding build operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! LGTM 🥳
Build max-parallelism can be controlled, but this takes place on the builder side: https://github.com/docker/buildx/blob/master/docs/guides/resource-limiting.md#max-parallelism |
9bc188b
to
3078aee
Compare
3078aee
to
5bde50d
Compare
Codecov ReportBase: 77.02% // Head: 77.02% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10030 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 2 2
Lines 235 235
=======================================
Hits 181 181
Misses 48 48
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Nicolas De Loof <[email protected]>
5bde50d
to
a0acc20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What I did
Introduce
--parallel=<int>
for user to limit the concurrency during image pullscould be later applied to other operations, typically
build
with adequate buildx|kit support for thisRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did