Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discontinue dartanalyzer #48457

Closed
4 of 5 tasks
mit-mit opened this issue Feb 23, 2022 · 18 comments
Closed
4 of 5 tasks

Discontinue dartanalyzer #48457

mit-mit opened this issue Feb 23, 2022 · 18 comments
Assignees
@srawlins @jcollins-g
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas).
Milestone
August Release (D...

Comments

@mit-mit
Copy link
Member

mit-mit commented Feb 23, 2022 •
edited by jcollins-g
Loading

As part of the transition to the new unified dart developer tool, we're discontinuing dartanalyzer in favor of dart analyze. This issue tracks remaining clean-up items needed to fully discontinue dartanalyzer:
@mit-mit mit-mit mentioned this issue Feb 23, 2022
Closed
@eernstg

This comment was marked as off-topic.

Sign in to view
@mit-mit

This comment was marked as off-topic.

Sign in to view
@eernstg

This comment was marked as off-topic.

Sign in to view
@lrhn lrhn added the area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). label Feb 23, 2022
@mit-mit

This comment was marked as off-topic.

Sign in to view
@eernstg

This comment was marked as off-topic.

Sign in to view
@mit-mit

This comment was marked as off-topic.

Sign in to view
@eernstg

This comment was marked as off-topic.

Sign in to view
@mit-mit

This comment was marked as off-topic.

Sign in to view
@bkonyi
Copy link
Contributor

bkonyi commented Mar 15, 2022

@bwilkerson @srawlins can one of you take ownership of this? Ideally this would be done for 2.17.

@srawlins
Copy link
Member

No promises on the 2.17 bit 😬 but we can triage this.

@bkonyi
Copy link
Contributor

bkonyi commented Mar 17, 2022

No promises on the 2.17 bit grimacing but we can triage this.

I had a feeling, but that's not the end of the world. 2.18 should be fine :-)

This was referenced May 4, 2022
Closed
Closed
@mit-mit mit-mit added this to the August Release (Dart 2.18) milestone Jun 13, 2022
@srawlins
Copy link
Member

The necessary flags have been added to dart analyze.

@bkonyi
Copy link
Contributor

bkonyi commented Jun 20, 2022

What else is left to do here @srawlins?

@srawlins
Copy link
Member

I believe the Engprod team is tasked with the SDK test tool's use of dartanalyzer.

@athomas
Copy link
Member

athomas commented Jun 21, 2022

@srawlins wasn't on my radar. In general, EngProd can help out but we can't scale to feature development. My view is that teams own the part of the test_runner that runs their code. There aren't many references to dartanalyzer though (there might be some in the benchmarks though I believe that has already been cleaned up):
https://cs.opensource.google/search?q=dartanalyzer%20f:test_runner&sq=&ss=dart%2Fsdk

The tricky bit is if there are options dartanalyzer supported that aren't supported on dart analyze but are used by test_runner. The analyzer team will be much better equipped to deal with those.

@jcollins-g jcollins-g self-assigned this Jun 22, 2022
@srawlins
Copy link
Member

Thanks for the details, @athomas. @jcollins-g is going to look into the test runner's use of dartanalyzer.

@jcollins-g
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/249662 will take care of removing dartanalyzer and references to it (WIP, I'm currently sending it to bots to try and track down anything I missed). For removing the package, I'm proposing we mark the package obsolete in pub, alter the README to be a short blurb referencing the removal issue, and stripping the tool of all functionality not needed by the SDK build and test framework.

copybara-service bot pushed a commit that referenced this issue Jul 1, 2022
@jcollins-g
Remove dartanalyzer from built SDK.
822cd1c 
Bug: #48457
Change-Id: Ic0d038299712989b8445859590ff870ce3bdc13a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249662
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Janice Collins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@eernstg eernstg mentioned this issue Jul 11, 2022
Open
@mit-mit
Copy link
Member Author

mit-mit commented Jul 18, 2022 •
edited
Loading

Thanks @jcollins-g!

For removing the package, I'm proposing we mark the package obsolete in pub

This was done a little while ago.

alter the README to be a short blurb referencing the removal issue

Looks like this already happened; I made a few further tweaks here:
https://dart-review.googlesource.com/c/sdk/+/251763

and stripping the tool of all functionality not needed by the SDK build and test framework.

Can we file a separate cleanup issue for that?

@mit-mit mit-mit closed this as completed Jul 19, 2022
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
@whesse
Remove dartanalyzer from SDKArtifactSizes benchmark
3eaf01a 
Bug: #48457
Change-Id: I42d2053e193f903ccf1eb9f351c0890dbd2231d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251945
Reviewed-by: Michael Thomsen <[email protected]>
@jcollins-g jcollins-g mentioned this issue Jul 27, 2022
Open
copybara-service bot pushed a commit that referenced this issue May 22, 2024
@DanTup
[analysis_server] Remove redundant solo_test tests
0f05924 
Checking for solo tests is now done as part of `verify_tests_test.dart` so solo tests currently produce two test failures.

This file did check one additional project that doesn't have `verify_tests_test.dart` does not (analyzer_cli) so it isn't exactly the same, but that project is going away (#48457) so it doesn't seem worth making `verify_tests_test` work there (there's a mismatch because it currently uses `all.dart` and not `test_all.dart`, but I suspect that filename may be coded into some bot configuration somewhere).

Change-Id: I7431ed0e141bab1898860f6fbe316833281d6fa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367620
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

@jcollins-g jcollins-g

Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas).
Projects
None yet
Milestone
August Release (Dart 2.18)
Development

No branches or pull requests
7 participants
@srawlins @lrhn @eernstg @mit-mit @jcollins-g @athomas @bkonyi