-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More decaff for issue 678 #6075
More decaff for issue 678 #6075
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
7174c03
to
bbbec3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things to look at. Should be good to merge after that.
bbbec3b
to
002459f
Compare
002459f
to
8f11448
Compare
8f11448
to
a5877ce
Compare
I was again careless about the translated code quality. Thank you for thorough review.
|
NEVER SQUASH THIS PR.