Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLM query example with Ollama #94

Merged
merged 29 commits into from
Dec 30, 2024
Merged

Add LLM query example with Ollama #94

merged 29 commits into from
Dec 30, 2024

Conversation

ehsantn
Copy link
Collaborator

@ehsantn ehsantn commented Dec 27, 2024

Changes included in this PR

Adds an example that demonstrates preprocessing data and querying an LLM using Bodo (with Ollama).

Testing strategy

Tested it locally.

User facing changes

A new example.

Checklist

  • [N/A] Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

Base automatically changed from ehsan/jit_wrapper to main December 27, 2024 22:34
Copy link
Contributor

@scott-routledge2 scott-routledge2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a larger dataset of queries we could use to show performance benefits over python?

@ehsantn
Copy link
Collaborator Author

ehsantn commented Dec 30, 2024

Running LLMs locally without GPUs is very slow so larger data would make it not usable.

@marquisdepolis
Copy link
Contributor

marquisdepolis commented Dec 30, 2024 via email

Copy link
Contributor

@marquisdepolis marquisdepolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd edit to model="llama3", or even make that an outside variable, to keep it cleaner. And add a comment next to raw_prompts*10 that this just runs the examples 10x times.

@ehsantn
Copy link
Collaborator Author

ehsantn commented Dec 30, 2024

Done.

@ehsantn ehsantn merged commit 33fad93 into main Dec 30, 2024
8 checks passed
@ehsantn ehsantn deleted the ehsan/ollama_example branch December 30, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants