Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bodo compatible with newer pandas versions to enable UDF engine support #92

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

scott-routledge2
Copy link
Contributor

@scott-routledge2 scott-routledge2 commented Dec 27, 2024

Changes included in this PR

Currently import bodo and running simple jit functions in the pandas development environment does not work because the pandas version is newer and some module/apis have been removed.

SingleArrayManager, ArrayManager and _get_option are removed in newer versions of pandas. Fill them with dummy values if they can't be imported since BlockManager/SingleBlockManager is always used.

pd.read_gbq was removed in newer pandas versions

Testing strategy

Unit tests added to pandas repo

User facing changes

No.

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

@scott-routledge2 scott-routledge2 changed the title [WIP] Make bodo compatible with newer pandas versions to enable UDF engine support Make bodo compatible with newer pandas versions to enable UDF engine support Dec 27, 2024
@scott-routledge2 scott-routledge2 marked this pull request as ready for review December 27, 2024 19:38
Copy link
Collaborator

@ehsantn ehsantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @scott-routledge2 .

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@986515d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage        ?   77.79%           
=======================================
  Files           ?      160           
  Lines           ?    61942           
  Branches        ?     8754           
=======================================
  Hits            ?    48189           
  Misses          ?    11627           
  Partials        ?     2126           

@scott-routledge2 scott-routledge2 merged commit 80ef759 into main Dec 27, 2024
20 of 21 checks passed
@scott-routledge2 scott-routledge2 deleted the scott/pandas_dev_compat branch December 27, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants