Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov #69

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Add Codecov #69

merged 8 commits into from
Dec 20, 2024

Conversation

hadia206
Copy link
Contributor

@hadia206 hadia206 commented Dec 15, 2024

Changes included in this PR

Use Codecov instead of SonarQube

Testing strategy

Right now there's no base that has coverage information so need to merge this first.
Once the initial PR is merged, subsequent PRs will show how your changes affect the overall project coverage as Codecov will now have a base to compare against.

User facing changes

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@2cc26f0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage        ?   77.81%           
=======================================
  Files           ?      160           
  Lines           ?    61894           
  Branches        ?     8750           
=======================================
  Hits            ?    48165           
  Misses          ?    11604           
  Partials        ?     2125           

Copy link
Contributor

@IsaacWarren IsaacWarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hadia

Copy link
Contributor

@srilman srilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @hadia206.

@srilman srilman marked this pull request as ready for review December 20, 2024 17:39
@srilman srilman merged commit 8ba18af into main Dec 20, 2024
20 of 21 checks passed
@srilman srilman deleted the Hadia/codecov branch December 20, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants