Simplify code quality in BodoRexSimplify

[njriasan]

Changes included in this PR

Aims to cleanup minor code details to have better examples for extending rex simplification.

Testing strategy

Depends on PR CI.

User facing changes

Checklist

• Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
• I am familiar with the Contributing Guide
• I have installed + ran pre-commit hooks.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@bb0bdb3). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage        ?   77.87%           
=======================================
  Files           ?      160           
  Lines           ?    62017           
  Branches        ?     8745           
=======================================
  Hits            ?    48295           
  Misses          ?    11596           
  Partials        ?     2126           

[IsaacWarren]

Thanks Nick, only comment is formatting, this looks like it uses 4 space indent when I thought calcite uses 2, maybe this file is just misformatted?

[njriasan]

Thanks Nick, only comment is formatting, this looks like it uses 4 space indent when I thought calcite uses 2, maybe this file is just misformatted?

This actually our file. One thing we should fix is that right now we say "don't apply the formatter on any Calcite source files", but ideally we could either apply Calcite's formatter to our files that we insert in their package (my preference) or just apply our formatter.