-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use warning instead of value error when tests are not being run in check_query
#118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many tests was this an issue for? Thanks Scott
@IsaacWarren It's a lot, maybe around 300? Not sure how many separate tests there are though. |
Do we know when this started? Seems concerning, should we try to fix them instead of merging this? That seems like too many broken tests to do a release IMO |
Looks like this is reverting a change from a recent PR: https://github.com/bodo-ai/Bodo/pull/83/files#diff-371bc62229377d93fed7d1bb28fbb123437b4f9d6bf9c1675de84f2ef9d14da7L325 |
Ah ok, thanks for the context, approving |
@IsaacWarren It is sort of by design that the tests aren't being run in certain situations on azure to save time since we know another runner will run the test. So for example if The warning was added here because we had a situation where we were testing something with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage ? 77.84%
=======================================
Files ? 160
Lines ? 62064
Branches ? 8769
=======================================
Hits ? 48312
Misses ? 11627
Partials ? 2125 |
Changes included in this PR
As titled. This is to enable a green nightly, we can later go back and look at the tests that failed on an individual basis to see if they need to be removed/reworked.
Testing strategy
Locally/on CI
User facing changes
No
Checklist
[run CI]
in your commit message.