Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use warning instead of value error when tests are not being run in check_query #118

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

scott-routledge2
Copy link
Contributor

@scott-routledge2 scott-routledge2 commented Jan 6, 2025

Changes included in this PR

As titled. This is to enable a green nightly, we can later go back and look at the tests that failed on an individual basis to see if they need to be removed/reworked.

Testing strategy

Locally/on CI

User facing changes

No

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

@scott-routledge2 scott-routledge2 marked this pull request as ready for review January 6, 2025 20:19
Copy link
Contributor

@IsaacWarren IsaacWarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many tests was this an issue for? Thanks Scott

@scott-routledge2
Copy link
Contributor Author

@IsaacWarren It's a lot, maybe around 300? Not sure how many separate tests there are though.

@IsaacWarren
Copy link
Contributor

@IsaacWarren It's a lot, maybe around 300? Not sure how many separate tests there are though.

Do we know when this started? Seems concerning, should we try to fix them instead of merging this? That seems like too many broken tests to do a release IMO

@ehsantn
Copy link
Collaborator

ehsantn commented Jan 6, 2025

Looks like this is reverting a change from a recent PR: https://github.com/bodo-ai/Bodo/pull/83/files#diff-371bc62229377d93fed7d1bb28fbb123437b4f9d6bf9c1675de84f2ef9d14da7L325

@IsaacWarren
Copy link
Contributor

Looks like this is reverting a change from a recent PR: https://github.com/bodo-ai/Bodo/pull/83/files#diff-371bc62229377d93fed7d1bb28fbb123437b4f9d6bf9c1675de84f2ef9d14da7L325

Ah ok, thanks for the context, approving

@scott-routledge2
Copy link
Contributor Author

scott-routledge2 commented Jan 6, 2025

@IsaacWarren It is sort of by design that the tests aren't being run in certain situations on azure to save time since we know another runner will run the test. So for example if check_query is passed as only_1D_jit=True it is skipped on one rank but the test still gets executed in the multi rank case.

The warning was added here because we had a situation where we were testing something with only_1D_jit and inspecting the logs which failed because the test wasn't being run on one rank.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a28fb89). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage        ?   77.84%           
=======================================
  Files           ?      160           
  Lines           ?    62064           
  Branches        ?     8769           
=======================================
  Hits            ?    48312           
  Misses          ?    11627           
  Partials        ?     2125           

@scott-routledge2 scott-routledge2 merged commit 591b18e into main Jan 6, 2025
20 of 21 checks passed
@scott-routledge2 scott-routledge2 deleted the scott/check_query_warning branch January 6, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants