CordovaLib.xcodeproj file upgraded for Xcode 10 #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 74.75% 74.75%
=======================================
Files 11 11
Lines 1822 1822
=======================================
Hits 1362 1362
Misses 460 460Continue to review full report at Codecov.
|
|
Looks like the TravisCI tests all pass with Xcode 9. However, we don't seem to have Xcode 10 TravisCI tests in the matrix |
|
@shazron I've reduced this back to just the CordovaLib.xcodeproj and CordovaLib deprecation changes, and added Xcode 10.1 to the CI matrix on Travis (while keeping a single run of Xcode 9.3 as a backward-compatibility check, pending further discussion) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
Upgrades CordovaLib.xcodeproj to Xcode 10 standards
What testing has been done on this change?
All the objc unit tests pass locally with Xcode 10.1, opening this PR to see how they are handled by Xcode 9.