Fix crash when enabling profiler #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asherkin
reviewed
Feb 4, 2019
When a plugin is currently executing code while the profiler is being activated, the VM tried to leave a profiling scope it never entered. `sm_rcon sm prof start vprof` would crash the server.
fc08193 to
0675bac
Compare
peace-maker
added a commit
to peace-maker/sourcepawn
that referenced
this pull request
Jul 15, 2019
The crash fix in alliedmodders#316 didn't initialize the member variable, so it doesn't really fix the issue. It seems I just got tricked during testing with debug builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a plugin is currently executing code while the profiler is being activated, the VM tried to leave a profiling scope it never entered.
sm_rcon sm prof start vprofwould crash the server.https://crash.limetech.org/lgolraffyt46