-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PannerNode refDistance description unclear #2184
Comments
Teleconf: This makes sense and clarifies the behavior. We'll add this. |
But instead of saying
I think it's better to say something like
because the current spec already says the volume is being reduced. Thanks for bringing this to our attention. |
Just mention that the volume is not reduced when the distance is less than the refDistance.
Yes that sounds good to me. Sorry I was a bit quick about closing this issue, I did not notice this commit was on a fork. |
No problem. When the PR lands, this issue will get closed automatically. |
The current description for the
refDistance
attribute [1] isFrom the formulas for each
DistanceModelType
[2] one can deduce that it is the distance at which there is no reduction in volume (gain=1). To me this is not clear from the description above.For further clarification I suggest adding at least a sentence like
If it is just me or you think the formulas in the specification are enough to describe this, feel free to just close & dismiss this issue.
[1] https://webaudio.github.io/web-audio-api/#dom-pannernode-refdistance
[2] https://webaudio.github.io/web-audio-api/#dom-distancemodeltype-linear
The text was updated successfully, but these errors were encountered: