Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioWorkletProcessor definition without get ParameterDescriptor #2171

Closed
padenot opened this issue Mar 3, 2020 · 1 comment · Fixed by #2172
Closed

AudioWorkletProcessor definition without get ParameterDescriptor #2171

padenot opened this issue Mar 3, 2020 · 1 comment · Fixed by #2172

Comments

@padenot
Copy link
Member

padenot commented Mar 3, 2020

Should this be allowed? Per spec, it shouldn't:

https://heycam.github.io/webidl/#es-sequence throws if the input is not iterable, and there is particular handling for when there is no get parameterDescriptors.

I see WPTs and examples in the spec that don't have get parameterDescriptors.

@hoch, I believe your intent there was to allow it, is that right?

@padenot padenot added Needs Discussion The issue needs more discussion before it can be fixed. Untriaged labels Mar 3, 2020
padenot added a commit to padenot/web-audio-api that referenced this issue Mar 3, 2020
This allows omitting it if a particular Processor is not going to use
AudioParam. However, if the getter is specified, then it MUST return an
iterable.

This fixes WebAudio#2171.
@rtoy
Copy link
Member

rtoy commented Mar 12, 2020

Teleconf: Allow not having parameterDescriptors. Makes sense if there are no AudioParams defined for the worklet.

@rtoy rtoy removed the Untriaged label Mar 12, 2020
@rtoy rtoy removed the Needs Discussion The issue needs more discussion before it can be fixed. label Mar 12, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 27, 2020
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Mar 31, 2020
…ioWorkletProcessor. r=karlt

WebAudio/web-audio-api#2171

Differential Revision: https://phabricator.services.mozilla.com/D65154

UltraBlame original commit: c1e0df633ac84db8c51bb5ab9ed10fc37c7b1533
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Mar 31, 2020
…ioWorkletProcessor. r=karlt

WebAudio/web-audio-api#2171

Differential Revision: https://phabricator.services.mozilla.com/D65154

UltraBlame original commit: c1e0df633ac84db8c51bb5ab9ed10fc37c7b1533
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Mar 31, 2020
…ioWorkletProcessor. r=karlt

WebAudio/web-audio-api#2171

Differential Revision: https://phabricator.services.mozilla.com/D65154

UltraBlame original commit: c1e0df633ac84db8c51bb5ab9ed10fc37c7b1533
padenot added a commit that referenced this issue Apr 29, 2020
This allows omitting it if a particular Processor is not going to use
AudioParam. However, if the getter is specified, then it MUST return an
iterable.

This fixes #2171.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants