Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IIRFilterOptions description makes impossible demands #2148

Closed
bzbarsky opened this issue Feb 7, 2020 · 1 comment
Closed

IIRFilterOptions description makes impossible demands #2148

bzbarsky opened this issue Feb 7, 2020 · 1 comment
Assignees
@rtoy

Comments

@bzbarsky
Copy link

bzbarsky commented Feb 7, 2020

https://webaudio.github.io/web-audio-api/#dom-iirfilteroptions-feedforward says:

If not specifed, a NotFoundError MUST be thrown

But the IDL for that member says required. That means that if it's not specified https://heycam.github.io/webidl/#es-to-dictionary step 4.1.5 will throw a TypeError before anythiing involving the Web Audio spec happens. So it's not clear to me what this NotFoundError requirement is about and how it can be complied with.

https://webaudio.github.io/web-audio-api/#dom-iirfilteroptions-feedback has the same issue.
@bzbarsky bzbarsky added Needs Discussion The issue needs more discussion before it can be fixed. Untriaged labels Feb 7, 2020
@padenot
Copy link
Member

padenot commented Feb 13, 2020

Telconf decision: Remove this check and exception throwing and let WebIDL do its thing.

@rtoy rtoy removed Needs Discussion The issue needs more discussion before it can be fixed. Untriaged labels Feb 13, 2020
@rtoy rtoy added the Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/ label Feb 13, 2020
rtoy added a commit to rtoy/web-audio-api that referenced this issue Feb 14, 2020
@rtoy
Fix WebAudio#2148: Fix erroneous IIRFilterOptions description
5eed94e 
Just remove the test that says if the option isn't specified throw an
error.  The option is required so this doesn't make sense.
@rtoy rtoy added In PR Review and removed Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/ labels Feb 14, 2020
@padenot padenot assigned padenot and rtoy and unassigned padenot Feb 14, 2020
@rtoy rtoy closed this as completed in a8b56c8 Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtoy rtoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@padenot @rtoy @bzbarsky