Link to correct algorithm for StereoPannerNode, mention algorithm is equal-power #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtoy
reviewed
Sep 24, 2018
index.bs
Outdated
| @@ -11506,7 +11506,7 @@ sound. | |||
| </figure> | |||
|
|
|||
| <h4 id="stereopanner-algorithm"> | |||
| StereoPannerNode Panning</h4> | |||
| StereoPannerNode Panning (equal-power only)</h4> | |||
There was a problem hiding this comment.
Don't think saying equal-power only adds anything. And nowhere in the algorithm does it say equal-power.
There was a problem hiding this comment.
I mentioned it because it was mentioned in the link, but I'll remove both
index.bs
Outdated
| @@ -9034,7 +9034,7 @@ Attributes</h4> | |||
| The {{StereoPannerNode}} Interface</h3> | |||
|
|
|||
| This interface represents a processing node which positions an | |||
| incoming audio stream in a stereo image using a low-cost <a href="#Spatialization-equal-power-panning">equal-power panning | |||
| incoming audio stream in a stereo image using <a href="#stereopanner-algorithm">a low-cost equal-power panning | |||
There was a problem hiding this comment.
Maybe we should just leave out "equal-power"? If so, we should also remove "equai-power" from the API Overview for the stereo panner.
StereoPannerNode currently links to PannerNode's algorithm, which asks for the computation of the azimuth. This isn't necessary, StereoPannerNode's `pan` argument is the equivalent of the azimuth, in different units.
205a853
to
113885f
Compare
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StereoPannerNode currently links to PannerNode's algorithm, which asks for the computation of the azimuth. This isn't necessary, StereoPannerNode's
panargument is the equivalent of the azimuth, in different units.r? @rtoy
Preview | Diff