-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify or Update reportEvent Destinations #441
Comments
I wonder what would be a use case for |
@trentunderwood : your definition of seller and component-seller is correct. IIUC the concern raised is that a reportEvent call is not aware of whether to send a beacon to the top-level seller or the component seller. Since registerAdBeacon can be invoked from both top-level and component sellers and reportEvent can contain [componentSeller, seller] to send a beacon to both, is that sufficient for your workflow? |
Or is the workflow such that top-level seller needs to be excluded from receiving the beacon which is not possible because reportEvent caller wouldn't know whether to put in seller or component seller? |
Sort of. I imagine buyers might generally want to report events to the seller with which they have a direct relationship. Since an ad can't know whether it won a single or multi seller auction, a buyer might use To @sbelov's question, I'm not actually sure what would be a use case for a buyer to report an event to the top-level seller in a multi-seller auction. |
@trentunderwood framing seller destinations around direct or indirect seems reasonable. I wonder someone could chime in from a potential FLEDGE buyer perspective. |
In the interest of keeping the API surfaces changes minimum, a possible approach is to add an additional direct-seller destination type. For single-level auctions, seller and direct-seller both imply the same. |
@shivanigithub Thank you! I believe "direct-seller" should work. Do you have a timeline on when this could be added? |
The "direct-seller" destination is an alias for whichever seller is dealing directly with the buyer. It corresponds to the "seller" in a single-layer auction and the "component-seller" in a multi-layer auction. From the discussion in WICG/turtledove#441. Change-Id: I334501296dccce0015c4f403f4ed5e337403f5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4282418 Reviewed-by: Caleb Raitto <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1108577}
The "direct-seller" destination was added in Chrome M112, and should already be available in the canary and development branches. It goes to beta on March 9, 2023 and stable on April 4, 2023. |
I think this issue is resolved. Feel free to reopen or file a new issue if you have more questions or issues. |
Currently,
reportEvent
supports two “seller” destinations:seller
andcomponent-seller
. The documentation does not define what these destinations refer to in a single-seller versus a multi-seller auction.A naive guess might suppose that
seller
refers to only the top-level seller in a multi-seller auction and thatcomponent-seller
does not refer to anyone in a single-seller auction.Can we clarify whether this is indeed the case, and if not, add additional details to the documentation to clarify what these destinations mean?
If it is the case, then the current
reportEvent
API may be insufficient for buyers’ needs. This is because a buyer will likely need to report certain events to the “immediate” seller, meaning they would need to useseller
as the destination if they won a single-seller auction, orcomponent-seller
if they won a multi-seller auction. This is problematic because the call toreportEvent
will be triggered from within an ad, where there is no ability to determine what type of auction was run.If the guess above is correct, then we propose two new seller destinations:
top-level-seller
: Refers to the only seller in a single-seller auction, or the top-level seller in a multi-seller auction.immediate-seller
: Refers to the only seller in a single-seller auction, and the component seller in a multi-seller auction.The text was updated successfully, but these errors were encountered: