Some API changes #125
Merged
Some API changes #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeng-scale
commented
Sep 18, 2023
| @@ -271,7 +271,7 @@ async def abort_request() -> None: | |||
|
|
|||
| def main(): | |||
| parser = argparse.ArgumentParser() | |||
| parser.add_argument("--host", type=str, default=None) | |||
| parser.add_argument("--host", type=str, default="127.0.0.1") | |||
There was a problem hiding this comment.
127.0.0.1 won't work in ipv6, can you change it back? if you don't like None i think 0.0.0.0 may work as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quality of life changes to API server. return number of tokens, token logprob and whether it finishes the request (in streaming). update dockerfile for better caching. formatting done with black.