misc(build): use git-describe for build bundle version header #14347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Sep 2, 2022
| @@ -251,6 +254,5 @@ if (esMain(import.meta)) { | |||
| } | |||
|
|
|||
| export { | |||
| COMMIT_HASH, | |||
adamraine
approved these changes
Sep 2, 2022
|
fwiw this describe string means its 248 commits past the v9.5.0 tag. (which it is) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learned about
git-describethis week.Gives us this header at the top of our bundles:
Lighthouse v9.5.0-248-gad6f1dba7 (Sep 02 2022)(prev:Lighthouse v9.5.0 <whatever the commit sha is> (Sep 02 2022)). Note thatgad6f1dba7is a reference to the commit's first git object, not the commit itself–but the entire thing is itself a valid ref specifier (in other words,git show v9.5.0-248-gad6f1dba7works butgit show gad6f1dba7is nonsense)We don't ship non-tagged versions most of the time, but we do regularly to LR's canary feed.