tests: static-server can continue if already running #14307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Aug 23, 2022
cli/test/fixtures/static-server.js
Outdated
Comment on lines
260
to
266
| await Promise.allSettled(servers.map(s => s.listen(s._port, 'localhost'))).then(outcomes => { | ||
| if (outcomes.every(o => o.status === 'fulfilled')) return; | ||
| if (outcomes.every(o => o.reason.message.includes('already'))) { | ||
| return console.warn('😧 Server already up. Continuing…'); | ||
| } | ||
| console.error(outcomes.map(o => o.reason)); | ||
| }); |
There was a problem hiding this comment.
For readability, will this work?
Also we should probably throw an error if the servers fail for an unknown reason
Suggested change
| await Promise.allSettled(servers.map(s => s.listen(s._port, 'localhost'))).then(outcomes => { | |
| if (outcomes.every(o => o.status === 'fulfilled')) return; | |
| if (outcomes.every(o => o.reason.message.includes('already'))) { | |
| return console.warn('😧 Server already up. Continuing…'); | |
| } | |
| console.error(outcomes.map(o => o.reason)); | |
| }); | |
| const outcomes = await Promise.allSettled(servers.map(s => s.listen(s._port, 'localhost'))); | |
| if (outcomes.some(o => o.status === 'rejected')) { | |
| if (outcomes.every(o => o.reason.message.includes('already'))) { | |
| console.warn('😧 Server already up. Continuing…'); | |
| } else { | |
| console.error(outcomes.map(o => o.reason)); | |
| throw new Error('One or more servers did not start correctly'); | |
| } | |
| } | |
| return servers |
There was a problem hiding this comment.
your await flow is definitely better. and fixes the error throwing. (i was ending up with an unhandled rejection previously)
i do still prefer the style of my two every()s, but whatever. definitely not a big deal.
There was a problem hiding this comment.
@adamraine thanks for writing out the suggestion! :) so clean.
connorjclark
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14302
not trying to get fancy. these are pretty unique ports.