misc(build): shim fs out of lightrider report generator bundle

[brendankenny]

from my too-late comment in #14031. We shim fs this way for the standalone report umd bundle, can do the same thing here. Still a workaround, but a little less finicky.

[paulirish]

works for me.

[connorjclark]

Does someone need to confirm it works when improving to google3?

[brendankenny]

Probably smart, but FWIW here's the diff from the current version:

diff --git a/dist/lightrider/report-generator-bundle.js b/report-generator-bundle.js
index 1627f073c..3a507a5e9 100644
--- a/dist/lightrider/report-generator-bundle.js
+++ b/dist/lightrider/report-generator-bundle.js
@@ -1,5 +1,8 @@
-var ReportGenerator = (function () {
-	'use strict';
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
+	typeof define === 'function' && define.amd ? define(factory) :
+	(global = typeof globalThis !== 'undefined' ? globalThis : global || self, global.ReportGenerator = factory());
+}(this, (function () { 'use strict';
 
 	function getAugmentedNamespace(n) {
 		if (n.__esModule) return n;
@@ -224,6 +227,4 @@ var ReportGenerator = (function () {
 
 	return reportGenerator;
 
-}());
-
-window.ReportGenerator = ReportGenerator;
+})));

no require('fs')

[paulirish]

Does someone need to confirm it works when improving to google3?

yes. i was being lazy but.. yes.

anyway, just tried it

did a cherrypick of 36787c6 on top of the 961branch thats in use there.

ran the renderer tests and also built lr:app. while the latter would break (before #14031 and stuff), it's good here (again).

🔒 http://go/wahgd 👍