-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: replace jest with mocha #14054
Conversation
The glob / test filter is not working on Windows (0 tests running), gotta look into that. |
mkay i'll use the new fancy thing instead. |
} | ||
|
||
const baseArgs = [ | ||
'--require=lighthouse-core/test/test-env/mocha-setup.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about a .mocharc.js file?
is going full CLI flag just easier given the permutations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file just extracts what you'd pass on the CLI to a file. It doesn't do what jest was doing, which was setting up its own environment for just those particular tests. That's the entire thing run-mocha-tests.js is doing. so in short:
is going full CLI flag just easier given the permutations?
Yeah
Windows is surely a dumb mistake in the process execution or paths or something, but I'm wasting way too much time trying to get a windows cloudtop to work at the office. I'll disable for now, and re-enable tomorrow when I'm back home with a windows machine to debug. |
Fixes #14047