report: avoid css issue with border when hoisting meta block #13877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested changes
Apr 19, 2022
| @@ -695,11 +695,10 @@ | |||
| border-top: 1px solid var(--report-border-color-secondary); | |||
| } | |||
|
|
|||
| .lh-metric:nth-last-child(-n+2) { | |||
| .lh-category:not(.lh--hoisted-meta) .lh-metric:nth-last-child(-n+2) { | |||
| border-bottom: 1px solid var(--report-border-color-secondary); | |||
There was a problem hiding this comment.
was thinking about how else to do this, and a :not(:last-child) ... almost works but lh-metrics-container isn't the last element normally anyways so nope.
…tes the metablock hoisting. drop it
ah true. yeah that has existed in the PSI report for a few months now. but its ugly. so yeah i put in a fix for it. |
|
I'll defer to @connorjclark |
| @@ -695,11 +695,10 @@ | |||
| border-top: 1px solid var(--report-border-color-secondary); | |||
| } | |||
|
|
|||
| .lh-metric:nth-last-child(-n+2) { | |||
| .lh-category:not(.lh--hoisted-meta) .lh-metric:nth-last-child(-n+2) { | |||
There was a problem hiding this comment.
since this is not trivial can you add a comment for why we are doing this? "avoid extraneous border when we move meta block into metrics div" or something
connorjclark
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this case we don't want some bottom borders if the meta block is right under the metrics.