Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: set encoding on streams for unicode correctness #13780

Merged
merged 5 commits into from
Mar 31, 2022
Merged

misc: set encoding on streams for unicode correctness #13780

merged 5 commits into from
Mar 31, 2022

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark requested a review from a team as a code owner March 24, 2022 18:08
@connorjclark connorjclark requested review from adamraine and removed request for a team March 24, 2022 18:08
@connorjclark
Copy link
Collaborator Author

there's also some vendored code for downloading chromium but i don't care to edit that

@connorjclark
Copy link
Collaborator Author

connorjclark commented Mar 24, 2022 •
edited
Loading

wtf is this
image

https://github.com/GoogleChrome/lighthouse/runs/5681247217?check_suite_focus=true#step:8:23

(probably unrelated to change... i hope)

@connorjclark
Copy link
Collaborator Author

^ not related, happened in the other PR touching these files too. so our build cache is cleared and latest code seems to break out tests

@connorjclark connorjclark merged commit 206b508 into master Mar 31, 2022
@connorjclark connorjclark deleted the encoding-utf8 branch March 31, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @adamraine @devtools-bot