-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CSS Grid #205
Implement CSS Grid #205
Conversation
FYI, if your work is still in progress it's good practice to mark the PR as draft: GitHub Docs This prevents merging of the PR before it's ready. You should be able to mark it as draft retroactively in the sidebar on the right, if IIRC. |
0bc2100
to
feeee35
Compare
As a heads up @nicoburns, I'd like to merge this relatively aggressively, then iterating on it in follow-up PRs before the next major version. Great work so far! It's a much easier workflow for collaboration than trying to get it perfect in the very first PR. |
@alice-i-cecile Good to know! I can break this up into smaller PRs if that would be helpful? And maybe add feature flags for flexbox and grid (flexbox defaulting to on, grid to off for now)? However this PR builds on top of #202 (as it already much of the work of nicely factoring out the existing flexbox implementation into it's own module). I'm not sure what the status on that PR is, but currently this one would be blocked on that one being merged. |
cab1677
to
ae69abb
Compare
0107203
to
610f013
Compare
ccc420b
to
9b0612d
Compare
…performing final positioning
…econdary axis position
I believe I have addressed all of your concerns/requests (in particular I've filled in the release notes). I have also:
As always, progress is being tracked over at #204. My suggestion is that we try to get this PR merged ASAP, but that we keep the issue open and continue to use it to track overall progress on Grid. I imagine the release notes might need some work, but I would like to suggest we start a new release issue/PR and don't block this PR on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome write-up! That was my last blocking request: I think that merging and iterating is the way to go now.
Objective
Fixes #204
Feedback wanted
Nothing in particular just yet. This PR is still very incomplete. Just putting it up early to track progress.